Remove pkg.grpc.exec from vmtests #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkourt
approved these changes
Aug 25, 2022
kkourt
added
the
needs-rebase
|
@tpapagian Thanks! Could you please rebase so that we can merge this? |
pkg.grpc.exec relies on sleep() calls in order to wait for the eventcache to run. Running them on heavily loaded VM cause flakes. As they are not kernel-dependant, let's run them only as part of gotests. Signed-off-by: Anastasios Papagiannis <[email protected]>
Doing asserts before the sleep is racy. Signed-off-by: Anastasios Papagiannis <[email protected]>
tpapagian
force-pushed
the
pr/apapag/remove_exectests_vmtests
branch
from
c15c072 to
1826955
Compare
@kkourt done! |
tpapagian
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkg.grpc.exec relies on sleep() calls in order to wait for the
eventcache to run. Running them on heavily loaded VM cause flakes.
As they are not kernel-dependant, let's run them only as part of
gotests.
Signed-off-by: Anastasios Papagiannis [email protected]