Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable copyfd test in vmtests #355

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Re-enable copyfd test in vmtests #355

merged 3 commits into from
Aug 25, 2022

Conversation

tpapagian
Copy link
Member

@tpapagian tpapagian commented Aug 23, 2022

As #247 is resolved, this PR tries to enable this test again.

Signed-off-by: Anastasios Papagiannis [email protected]

As #247 is resolved, this PR
tries to enable this test again.

Signed-off-by: Anastasios Papagiannis <[email protected]>
@tpapagian tpapagian requested a review from a team as a code owner August 23, 2022 08:42
@tpapagian tpapagian requested a review from kevsecurity August 23, 2022 08:42
@tpapagian tpapagian force-pushed the pr/apapag/enable_copyfd_test branch from 689dc51 to 84349fc Compare August 23, 2022 11:11
@tpapagian
Copy link
Member Author

tpapagian commented Aug 23, 2022

There is an issue with TestCopyFd only in 5.4 but now this is consistent and happens on every run. Not sure that this is fully related to the CopyFd test.

We used wrong timeout in TestCopyFd. Fixed in the last commit.

@tpapagian tpapagian marked this pull request as draft August 23, 2022 11:59
@tpapagian tpapagian force-pushed the pr/apapag/enable_copyfd_test branch 4 times, most recently from c6922cf to 32edc7a Compare August 23, 2022 17:09
@tpapagian tpapagian force-pushed the pr/apapag/enable_copyfd_test branch from 32edc7a to 811b17c Compare August 23, 2022 17:33
@tpapagian tpapagian changed the title Re-enable copyfd test Re-enable copyfd test in vmtests Aug 23, 2022
@tpapagian tpapagian marked this pull request as ready for review August 23, 2022 18:49
@kkourt kkourt merged commit f290431 into main Aug 25, 2022
@kkourt kkourt deleted the pr/apapag/enable_copyfd_test branch August 25, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants