Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/bpf: remove redundant check from HasLSMPrograms #3422

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

anfedotoff
Copy link
Contributor

Checking the contents of /sys/kernel/security/lsm file is redundant because later simple LSM program is loaded. File check makes problems when you trying to load LSM sensor in k8s cluster. We can remove this check without losing stability.

Fixes #3392

Some discussion can be found here: #3404

Checking the contents of /sys/kernel/security/lsm file is redundant
because later simple LSM program is loaded. File check makes problems
when you trying to load LSM sensor in k8s cluster. We can remove this
check without losing stability

Signed-off-by: Andrei Fedotov <[email protected]>
@anfedotoff anfedotoff requested a review from a team as a code owner February 19, 2025 18:21
@anfedotoff anfedotoff requested a review from jrfastab February 19, 2025 18:21
@mtardy mtardy added the release-note/misc This PR makes changes that have no direct user impact. label Feb 20, 2025
@mtardy mtardy self-requested a review February 20, 2025 10:49
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah thanks I fine it's fine to skip the /sys/kernel/security/lsm read and directly try to load a prog since this what we eventually want to do.

@kkourt kkourt merged commit 5a54e09 into cilium:main Feb 21, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with applying LSM policies in k8s cluster
3 participants