Podman-friendly CONTAINER_ENGINE setting #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitris
force-pushed
the
podman-friendly
branch
from
1b7bf3c to
97f7508
Compare
kkourt
reviewed
Aug 19, 2022
tests/vmtests/fetch-data.sh - allow overiting CONTAINER_ENGINE (with 'sudo podman' etc.) while keeping 'docker' as the default. Additionally add a link to the vmtests/README.md in the contributor guide. Signed-off-by: Dmitry Savintsev <[email protected]>
dmitris
force-pushed
the
podman-friendly
branch
from
81222aa to
9fa9ebd
Compare
|
@kkourt could you please restart the failed build? The build failure seems not related to this change. |
kkourt
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR changes the setting of
CONTAINER_ENGINEin tests/vmtests/fetch-data.sh to allow overwriting the variable with for examplesudo podmanwhile keepingdockeras the default. It also adds a link to the vmtests README in the contributor guide.Based on the Slack conversation https://cilium.slack.com/archives/C2B917YHE/p1660856168376349?thread_ts=1660843012.876959&cid=C2B917YHE - thanks @kkourt!