encoder: improve api to make it more generic #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the encoder to use concerete error types rather than fmt.Errorf. This would allow downstream consumers of the API to more easily match over the error. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/encoder-interface
branch
from
7dd119c to
ac7bdc4
Compare
Abstract the GetEncoder logic into a function so that downstream users can plug in their own encoders as they see fit. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/encoder-interface
branch
2 times, most recently
from
b0aa735 to
9b5b366
Compare
|
Still messing around with this, marking as draft |
willfindlay
force-pushed
the
pr/willfindlay/encoder-interface
branch
3 times, most recently
from
6b94489 to
30196a8
Compare
This change makes it easier to implement alternative encoder types in the future, for example by embedding the compact encoder inside another encoder struct. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/encoder-interface
branch
from
30196a8 to
04b96c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.