Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/e2e: dump checker type along with event body #333

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

willfindlay
Copy link
Contributor

We weren't dumping the checker type before which was making it difficult to discern which
checks were which in the dump. Add it to the dump here.

Signed-off-by: William Findlay [email protected]

@willfindlay willfindlay requested a review from a team as a code owner August 17, 2022 19:31
@willfindlay willfindlay requested a review from tpapagian August 17, 2022 19:31
We weren't dumping the checker type before which was making it difficult to discern which
checks were which in the dump. Add it to the dump here.

Signed-off-by: William Findlay <[email protected]>
@willfindlay willfindlay force-pushed the pr/willfindlay/even-better-dumps branch from 19e0b69 to 89c3482 Compare August 17, 2022 19:33
@willfindlay
Copy link
Contributor Author

Example JSON output after this change. Note that we now include checker type in the output.

[
  {
    "ProcessExecChecker": {
      "process": {
        "binary": {
          "operator": "suffix",
          "value": "curl"
        },
        "pod": {
          "namespace": {
            "operator": "full",
            "value": "skeleton"
          }
        }
      }
    }
  }
]

@jrfastab jrfastab merged commit 8ab3d3f into main Aug 17, 2022
@jrfastab jrfastab deleted the pr/willfindlay/even-better-dumps branch August 17, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants