Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/olsajiri/fixes #3323

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Pr/olsajiri/fixes #3323

wants to merge 8 commits into from

Conversation

olsajiri
Copy link
Contributor

No description provided.

Moving SizeWithSuffix to strutils package, so we can
use it from other places.

Signed-off-by: Jiri Olsa <[email protected]>
Adding support to allow to setup execve_map max entries,
so we can control the size of this map.

Signed-off-by: Jiri Olsa <[email protected]>
Adding execve-map-entries option to setup entries of execve_map map.

Signed-off-by: Jiri Olsa <[email protected]>
Adding TAIL_CALL_SETUP tail call index, which was missing
in the TAIL_CALL_* enum values.

Signed-off-by: Jiri Olsa <[email protected]>
Move '!enter' early in the function which will help following
changes to be more readable.

There's no functional change.

Signed-off-by: Jiri Olsa <[email protected]>
Passing execve_map_value directly to match_binaries to
eliminate superfluous event_find_curr in it.

Signed-off-by: Jiri Olsa <[email protected]>
Currently we store stats for updating/removing failures in one value,
so there's no way to find out what failed.

Adding extra entry in both stats maps:
  execve_map_stats
  tg_execve_joined_info_map_stats

so we can count these errors separately.

Also factoring the update code to get rid of some extra functions.

Signed-off-by: Jiri Olsa <[email protected]>
Based on previous commit changes changing the current stats metrics to
reflect that.

Now we have separate metric for  update and delete errors, like for
execve_map stats:

  tetragon_map_capacity{map="execve_map"} 10
  tetragon_map_entries{map="execve_map"} 10
  tetragon_map_errors_delete_total{map="execve_map"} 0
  tetragon_map_errors_update_total{map="execve_map"} 3

Signed-off-by: Jiri Olsa <[email protected]>
Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit b8fe12e
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/678fc919926b50000845706c
😎 Deploy Preview https://deploy-preview-3323--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@olsajiri olsajiri added the release-note/minor This PR introduces a minor user-visible change label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant