-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr/olsajiri/fixes #3323
Draft
olsajiri
wants to merge
8
commits into
main
Choose a base branch
from
pr/olsajiri/fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Pr/olsajiri/fixes #3323
+234
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving SizeWithSuffix to strutils package, so we can use it from other places. Signed-off-by: Jiri Olsa <[email protected]>
Adding support to allow to setup execve_map max entries, so we can control the size of this map. Signed-off-by: Jiri Olsa <[email protected]>
Adding execve-map-entries option to setup entries of execve_map map. Signed-off-by: Jiri Olsa <[email protected]>
Adding TAIL_CALL_SETUP tail call index, which was missing in the TAIL_CALL_* enum values. Signed-off-by: Jiri Olsa <[email protected]>
Move '!enter' early in the function which will help following changes to be more readable. There's no functional change. Signed-off-by: Jiri Olsa <[email protected]>
Passing execve_map_value directly to match_binaries to eliminate superfluous event_find_curr in it. Signed-off-by: Jiri Olsa <[email protected]>
Currently we store stats for updating/removing failures in one value, so there's no way to find out what failed. Adding extra entry in both stats maps: execve_map_stats tg_execve_joined_info_map_stats so we can count these errors separately. Also factoring the update code to get rid of some extra functions. Signed-off-by: Jiri Olsa <[email protected]>
Based on previous commit changes changing the current stats metrics to reflect that. Now we have separate metric for update and delete errors, like for execve_map stats: tetragon_map_capacity{map="execve_map"} 10 tetragon_map_entries{map="execve_map"} 10 tetragon_map_errors_delete_total{map="execve_map"} 0 tetragon_map_errors_update_total{map="execve_map"} 3 Signed-off-by: Jiri Olsa <[email protected]>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
olsajiri
added
the
release-note/minor
This PR introduces a minor user-visible change
label
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.