Dockerfile: incude tetragon version in the image #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, tetragon images do not incude the version. This is because we generate the version using git, and .git is in .dockerignore so it will not be copied over when we are bullding the image. Fix this by passing an appropriate build argument to docker build. Tested using: $ make image $ docker run -it --entrypoint /bin/sh cilium/tetragon:latest / # /usr/bin/tetragon time="2022-08-17T09:57:07Z" level=info msg="Starting tetragon" version=v0.8.0-478-g30eb03fbf ... Signed-off-by: Kornilios Kourtis <[email protected]>
kaworu
approved these changes
Aug 17, 2022
|
|
😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, tetragon images do not incude the version. This is because we
generate the version using git, and .git is in .dockerignore so it will
not be copied over when we are bullding the image.
Fix this by passing an appropriate build argument to docker build.
Tested using:
$ make image
$ docker run -it --entrypoint /bin/sh cilium/tetragon:latest
/ # /usr/bin/tetragon
time="2022-08-17T09:57:07Z" level=info msg="Starting tetragon" version=v0.8.0-478-g30eb03fbf
...
Signed-off-by: Kornilios Kourtis [email protected]