vmtests fixes and improvements #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 120' timeout was from before we had multiple groups. Decrease it to 60' Signed-off-by: Kornilios Kourtis <[email protected]>
Add a --just-build-image flag that will just build an image and not boot anything. This can be used to build the image in one environment (Linux) and run it on another (Macos). Signed-off-by: Kornilios Kourtis <[email protected]>
Add a --enable-hvf flag for acceleration in macos. Signed-off-by: Kornilios Kourtis <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
--just-boot does not work anymore because the service is executed even if it was not enabled. Not sure why. As a simple solution, don't add the service if user specifies --just-boot. Signed-off-by: Kornilios Kourtis <[email protected]>
In some cases (e.g., when running on Macos) we want to build the image in Linux first, and then run it elsewhere. We do this by using --just-build-image and --dont-rebuild-image. In those cases, dont create a randomized results directory because there is currently now way to communicate it between the different stages. A better solution might be to expose the configuration file between the two stages, so we might want do do something like that eventually. Signed-off-by: Kornilios Kourtis <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
gatherExportFiles never worked properly. We do not stringly need this because it also part of bugtool, but does not hurt to pick it up here as well. Signed-off-by: Kornilios Kourtis <[email protected]>
willfindlay
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits