ProcessCache: Disable interval test in VM #3179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TestProcessCacheInterval test is flaky in VMs, probably because it relies on timing. This commit disables the test in the vmtests. Signed-off-by: Kevin Sheldrake <[email protected]>
kevsecurity
added
the
release-note/misc
kevsecurity
deleted the
pr/kevsecurity/disable-process-cache-interval-test
branch
|
These tests seem flaky in general. Can we make them better/remove them? https://github.com/cilium/tetragon/actions/runs/12203108081/job/34045336907?pr=3176#step:9:160 |
I'm open to ideas of how we test timing-related functionality, without waiting with sleeps which are inherently flaky on cloud runners and especially in VMs. Simulating the delay by running the ticker function isn't the same as the normal order of events and doesn't check that the ticker is actually working. But testing a ticker is flaky when timing is flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TestProcessCacheInterval test is flaky in VMs, probably because it relies on timing. This commit disables the test in the vmtests.