ci/vmtest: disable fail-fast on test matrix #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GA defaults to fail-fast on matrix strategies. This means that if on of our test groups fails, it will cancel all the others. I think we really don't want this because 1. most of the other jobs will probably be almost completed anyways so cancelling them is not worth it and 2. more cancelled jobs means more jobs we need to re-run on flakes. Let's disable fail-fast for the reasons stated above. Signed-off-by: William Findlay <[email protected]>
kkourt
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GA defaults to fail-fast on matrix strategies. This means that if one of our test groups
fails, it will cancel all the others. I think we really don't want this because 1. most of
the other jobs will probably be almost completed anyways so cancelling them is not worth
it and 2. more cancelled jobs means more jobs we need to re-run on flakes.
Let's disable fail-fast for the reasons stated above.
Signed-off-by: William Findlay [email protected]