chore: use proper sha256 values for go images #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 8bd6295 updated the image tags of Dockerfile and Dockerfile.test but not the sha256 hashes. This meant that the old version was used since the tag is ignored in the present of the hash. Add the correct hashes: $ ~/src/cilium/images/scripts/get-image-digest.sh docker.io/library/golang:1.18.3-alpine3.15 sha256:f9181168749690bddb6751b004e976bf5d427425e0cfb50522e92c06f761def7 $ ~/src/cilium/images/scripts/get-image-digest.sh docker.io/library/golang:1.18.3 sha256:1650c170f3c55c158431cd35906cb6faf25f5c93b9d8850341c81e1236eaa745 fixes: 8bd6295 Signed-off-by: Kornilios Kourtis <[email protected]>
tpapagian
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 8bd6295 updated the image tags
of Dockerfile and Dockerfile.test but not the sha256 hashes. This meant
that the old version was used since the tag is ignored in the present of
the hash.
Add the correct hashes:
$ ~/src/cilium/images/scripts/get-image-digest.sh docker.io/library/golang:1.18.3-alpine3.15
sha256:f9181168749690bddb6751b004e976bf5d427425e0cfb50522e92c06f761def7
$ ~/src/cilium/images/scripts/get-image-digest.sh docker.io/library/golang:1.18.3
sha256:1650c170f3c55c158431cd35906cb6faf25f5c93b9d8850341c81e1236eaa745
fixes: 8bd6295
Signed-off-by: Kornilios Kourtis [email protected]