Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devel README.md: add podman instructions #306

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Aug 10, 2022

PR extends docs/contributing/development/README.md with instructions on using podman instead of docker.

@dmitris dmitris requested a review from a team as a code owner August 10, 2022 17:06
@dmitris dmitris requested a review from olsajiri August 10, 2022 17:06
Copy link
Contributor

@willfindlay willfindlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

```
CONTAINER_ENGINE='sudo podman' make
```
You can ignore `/bin/sh: docker: command not found` in the output.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice if the docker command not found wasn't printed but I wont hold up the PR for this. Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know why it's being printed. I can probably fix it up tomorrow if nobody else gets to it first.

@jrfastab jrfastab merged commit c030a07 into cilium:main Aug 11, 2022
@dmitris dmitris deleted the doc-podman branch August 12, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants