eventcache: remove event.internal nil check for exec events #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was rightly pointed out that event.internal not being nil is an invariant here. If this ever changes accidentally we would probably want to know and in any case the panic would happen much earlier in the code path. So let's remove the nil check here. Signed-off-by: William Findlay <[email protected]>
tpapagian
approved these changes
Aug 9, 2022
kkourt
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was rightly pointed out that event.internal not being nil is an invariant here. If this
ever changes accidentally we would probably want to know and in any case the panic would
happen much earlier in the code path. So let's remove the nil check here.
Signed-off-by: William Findlay [email protected]