-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added metrics for LRU data cache #2908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @AshishNaware, overall looks good to me. I left two comments about small details.
Tetragon metrics are also documented in a generated reference doc, so the new metrics must be added there too. To generate the metrics reference, run:
make metrics-docs
Then you should see updated doc files.
As a side note, at some point it might be nice to refactor, to have both process and observer cache use the same cache implementation, but with separate metrics. But this is out of scope in this PR.
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
15b7a6b
to
dc13ea6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks!
@AshishNaware Could you please squash the three commits and force push? That's a practice in the Tetragon project, to keep clean git history on the main branch. Currently one of the CI jobs is failing because one of the commit messages is too long. |
dc13ea6
to
6f1f0ce
Compare
Signed-off-by: Ashish Naware <[email protected]>
6f1f0ce
to
bd325a0
Compare
@lambdanis @mtardy - I have squashed the commits and rebased the branch. This PR has now passed all the checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! :)
Fixes #679
Description
This PR adds additional metrics around LRU data cache such as size, capacity, evictions and cache miss in order to have a same set of metrics collection across the board.
Changelog