Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs for followChildren true #2858

Merged
merged 1 commit into from
Sep 2, 2024
Merged

docs for followChildren true #2858

merged 1 commit into from
Sep 2, 2024

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Sep 2, 2024 •
edited
Loading

Docs for #2720

@kkourt
docs for followChildren true
8e333b6 
Signed-off-by: Kornilios Kourtis <[email protected]>
@kkourt kkourt added the release-note/docs This PR updates the documentation. label Sep 2, 2024
@kkourt kkourt requested review from mtardy and a team as code owners September 2, 2024 08:16
@netlify Netlify
Copy link

netlify bot commented Sep 2, 2024

✅ Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 8e333b6
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66d57451dad9d50008a9f312
😎 Deploy Preview https://deploy-preview-2858--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mtardy
mtardy approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

nit: we can use caution or warning block for the limitation so that they stand out but that is perfectly fine like this.

@kkourt
Copy link
Contributor Author

kkourt commented Sep 2, 2024

Thanks.

nit: we can use caution or warning block for the limitation so that they stand out but that is perfectly fine like this.

Haven't thought of that but caution or warning seems more scary that I would like it to be. I don't feel strongly, but I think I'll keep it as is for now. We can always change it later.

@kkourt kkourt merged commit 8f9369b into main Sep 2, 2024
12 checks passed
@kkourt kkourt deleted the pr/kkourt/mb-followchildren-docs branch September 2, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtardy mtardy mtardy approved these changes

Assignees
No one assigned
Labels
release-note/docs This PR updates the documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkourt @mtardy