Replace process cache evictions and misses metrics #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdanis
added
area/metrics
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Use new helpers from pkg/metrics to define custom metrics and collector. There are no functional changes in this commit. Signed-off-by: Anna Kapuscinska <[email protected]>
It's duplicating tetragon_errors_total{type="process_cache_evicted"}, which
will be removed in a follow up commit.
Signed-off-by: Anna Kapuscinska <[email protected]>
It's duplicating
tetragon_errors_total{type=~"process_cache_miss_on_get|process_cache_miss_on_remove"},
which will be removed in a follow up commit.
Signed-off-by: Anna Kapuscinska <[email protected]>
Stop reporting tetragon_errors_total metric with "type" label values:
process_cache_miss_on_get
process_cache_evicted
process_cache_miss_on_remove
Evictions and misses are not errors, this is just cache's life, sometimes you
hit, sometimes you miss, and sometimes you gotta evict a process.
They are now reported by more intuitive metrics:
tetragon_process_cache_evictions_total
tetragon_process_cache_misses_total{operation=~"get|remove"}
Signed-off-by: Anna Kapuscinska <[email protected]>
lambdanis
force-pushed
the
pr/lambdanis/cache-metrics
branch
from
ef89465 to
c7354b0
Compare
kevsecurity
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop reporting tetragon_errors_total metric with "type" label values:
process_cache_miss_on_getprocess_cache_evictedprocess_cache_miss_on_removeEvictions and misses are not errors, this is just cache's life, sometimes you
hit, sometimes you miss, and sometimes you gotta evict a process.
They are now reported by more intuitive metrics:
tetragon_process_cache_evictions_totaltetragon_process_cache_misses_total{operation=~"get|remove"}Part of #2785