CI: Improve/stabilize lint Helm CI workflow #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipSchmid
force-pushed
the
pr/philip/ci_improve_lint_helm
branch
from
b725300 to
318bc58
Compare
PhilipSchmid
force-pushed
the
pr/philip/ci_improve_lint_helm
branch
3 times, most recently
from
7418a4d to
3c978f4
Compare
|
@PhilipSchmid could you rebase this perhaps? Otherwise not sure why the tarball test is failing. |
Only post the `Kubeconform Output` comment (on the affected GH PR) in case `kubeconform_min_k8s_version` OR `kubeconform_latest_k8s_version` is failed, not when they're `skipped` (e.g., in case a previous step fails). Signed-off-by: Philip Schmid <[email protected]>
PhilipSchmid
force-pushed
the
pr/philip/ci_improve_lint_helm
branch
from
3c978f4 to
b4f1eb4
Compare
|
Thanks, @willfindlay. Rebased to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only post the
Kubeconform Outputcomment (on the affected GH PR) in casekubeconform_min_k8s_versionORkubeconform_latest_k8s_versionis failed, not when they'reskipped(e.g., in case a previous step fails).I added write permissions to
pull-requestsbecause of https://github.com/cilium/tetragon/actions/runs/10580480940/job/29315446663#step:10:100.