e2e-framework: fix panic and bump event limit on demo app test #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently it's not idiomatic or correct to close a channel that has multiple writers [0]. Anyway this was causing an occaisional panic when testing on a cluster with more than one node because our goroutines were racing with each other and attempting to send after the channel was already closed. So let's just remove the close here. [0]: https://go101.org/article/channel-closing.html Signed-off-by: William Findlay <[email protected]>
When I was testing locally on my own GKE cluster I noticed that the test would occaisionally hit the checker time limit before the last elastic pod had a chance to spin up. Let's bump it to a more lenient 5 minutes and 5000 events to handle slower clusters a little better. Signed-off-by: William Findlay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bug fixes for e2e framework on GKE clusters. See individual commits.