fork_test: remove pid export filter #2831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in issue 2691, TestForm has been flaky. The way this test works is that a child is forked, which then forks a second chlid, which exits and we are looking for the exit event of the second child. My best guess on why the flake happens is that the pid filtering filters out the second exit event. This can happen, for example, if the pid cache of the pid filter has not yet seen an event with a known parent. So if the exit event of the second child comes before the exit event of the first chilid, then the first child's pid will not be in the cache when we get the second child exit and the event will be filtered out. Based on the above reasoning, this commit removes the pid filter for the test. Signed-off-by: Kornilios Kourtis <[email protected]>
kevsecurity
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue 2691, TestFork has been flaky. The way this test works is that a child is forked, which then forks a second chlid, which exits and we are looking for the exit event of the second child.
My best guess on why the flake happens is that the pid filtering filters out the second exit event. This can happen, for example, if the pid cache of the pid filter has not yet seen an event with a known parent.
So if the exit event of the second child comes before the exit event of the first chilid, then the first child's pid will not be in the cache when we get the second child exit and the event will be filtered out.
Based on the above reasoning, this commit removes the pid filter for the test.
Fixes: #2691