helm: Support adding extra labels to ServiceMonitors #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Labels on both tetragon and tetragon-operator ServiceMonitors can be overridden using tetragon[Operator].prometheus.ServiceMonitor.labelsOverride Helm values. However, it's nice to be able to add custom labels without overriding all of the default ones. Let's add such option via extraLabels Helm values. Signed-off-by: Anna Kapuscinska <[email protected]>
Signed-off-by: Anna Kapuscinska <[email protected]>
lambdanis
added
release-note/minor
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There is no need to use all labels as selectors in ServiceMonitors, and doing so might cause metrics loss during an upgrade. Signed-off-by: Anna Kapuscinska <[email protected]>
kkourt
approved these changes
Sep 2, 2024
|
@lambdanis LGTM, but I will leave merging to you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels on both tetragon and tetragon-operator ServiceMonitors can be overridden
using tetragon[Operator].prometheus.ServiceMonitor.labelsOverride Helm values.
However, it's nice to be able to add custom labels without overriding all of
the default ones. Let's add such option via extraLabels Helm values.
While here, use only selector labels as selectors in ServiceMonitors.
Related: #1820