helm: Add tetragon_pod label to metrics via ServiceMonitor #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdanis
added
area/metrics
Prometheus Operator by default adds "pod" label, representing the metrics exporter pod, to all scraped metrics. However, Tetragon exposes events metrics with "pod" label, which represents the process that generated events, not Tetragon pod. This label is not overridden if using the default ServiceMonitor (with "honorLabels: true") - that's good. However, it still can be useful to know which Tetragon pod exported the metric. Let's add "tetragon_pod" label to metrics scraped via default ServiceMonitor. Signed-off-by: Anna Kapuscinska <[email protected]>
lambdanis
force-pushed
the
pr/lambdanis/tetragon-labels-events-metrics
branch
from
e9356c4 to
571bac0
Compare
lambdanis
changed the title
olsajiri
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus Operator by default adds "pod" label, representing the metrics exporter pod, to all scraped metrics. However, Tetragon exposes events metrics with "pod" label, which represents the process that generated events, not Tetragon pod. This label is not overridden if using the default ServiceMonitor (with "honorLabels: true") - that's good. However, it still can be useful to know which Tetragon pod exported the metric. Let's add "tetragon_pod" label to metrics scraped via default ServiceMonitor.