tetragon: Update eventcache on New() call and cleanup old state #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if eventcache.New() is called multiple times the old cache will continue to be used. But, this is problematic if the caller is trying to configure the cache with new parameters, such as duration or exporter. Specifically this is the case in the unit tests where each Test* is creating a new process manager and exporter using a new file so that we have specific logs for each test. But, the current behavior means any events going through the eventcache (after the first test) are then lossed because they attempt to export into the old filename. To fix simply stop the old go() on New() and reconfigure it. When I ran this locally forcing all events through the cache I am now able to PASS multiple unit tests. Signed-off-by: John Fastabend <[email protected]>
michi-covalent
approved these changes
Aug 3, 2022
|
Yeah I guess that cache variable has become fairly useless... tbd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if eventcache.New() is called multiple times the old cache
will continue to be used. But, this is problematic if the caller is
trying to configure the cache with new parameters, such as duration
or exporter.
Specifically this is the case in the unit tests where each Test* is
creating a new process manager and exporter using a new file so that
we have specific logs for each test. But, the current behavior means
any events going through the eventcache (after the first test) are
then lossed because they attempt to export into the old filename.
To fix simply stop the old go() on New() and reconfigure it. When
I ran this locally forcing all events through the cache I am now
able to PASS multiple unit tests.
Signed-off-by: John Fastabend [email protected]