encoder: add compact fuzz tests and fix bugs related to unhandled event types #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Findlay <[email protected]>
This is needed to debug cases where the encoder fails to encode an unhandled event. Signed-off-by: William Findlay <[email protected]>
Signed-off-by: William Findlay <[email protected]>
Signed-off-by: William Findlay <[email protected]>
We have envountered issues with unhandled types slipping through the cracks in the compact encoder. Let's add a fuzz test that should help catch these cases in the future. Signed-off-by: William Findlay <[email protected]>
Signed-off-by: William Findlay <[email protected]>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
willfindlay
changed the title
willfindlay
added
the
release-note/bug
mtardy
reviewed
Aug 16, 2024
Do you have an alternative suggestion? I'd like to have these cases exercised in CI even under the normal |
jrfastab
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've been burned recently by unhandled event types in the compact encoder's code path. Introduce a new fuzz test for the compact encoder to ensure that we don't miss any in the future. A subsequent PR will introduce a new CI job that fuzzes for a little bit on every PR to try and catch any new cases that come up. For now, we use a static corpus.
The first fuzzing run found two unhandled event types:
Add an implementation for both of the above in the compact encoder.
Changelog