CI: Improved K8s Kubeconformance validation #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipSchmid
force-pushed
the
pr/philip/fix_ci_k8s_conformance_tests
branch
5 times, most recently
from
0db1c7e to
ba0809f
Compare
lambdanis
reviewed
Aug 16, 2024
lambdanis
reviewed
Aug 16, 2024
PhilipSchmid
force-pushed
the
pr/philip/fix_ci_k8s_conformance_tests
branch
7 times, most recently
from
ee59207 to
6074f22
Compare
lambdanis
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
looks good, thank you @PhilipSchmid! I left two small comments, but approving anyway.
|
@PhilipSchmid if you could address Anna's small comments then lets get this merged. Thanks. |
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PhilipSchmid
force-pushed
the
pr/philip/fix_ci_k8s_conformance_tests
branch
from
f32564e to
e47ffcd
Compare
- Improved Helm chart validation by using Kubeconformance with enabled CR validation. - Added JSON schemas for the Tetragon CRDs as we might need them in the future to validate CRs from the Helm chart (TPs, etc.). Signed-off-by: Philip Schmid <[email protected]>
PhilipSchmid
force-pushed
the
pr/philip/fix_ci_k8s_conformance_tests
branch
from
e47ffcd to
030c6d5
Compare
|
@jrfastab I implemented Anna's feedback, squashed and rebased to main and force-pushed, and all CI tests were successful. IMO, this is ready to be merged 🚀. |
lambdanis
approved these changes
Aug 20, 2024
PhilipSchmid
force-pushed
the
pr/philip/fix_ci_k8s_conformance_tests
branch
2 times, most recently
from
3d5d363 to
019837a
Compare
Signed-off-by: Philip Schmid <[email protected]>
PhilipSchmid
force-pushed
the
pr/philip/fix_ci_k8s_conformance_tests
branch
from
019837a to
7b0ef54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up PR of #2804
Changelog