Add test for tracing bpf_check #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a unit test for tracing bpf verifier checks during program loads. We do this by first loading a CRD that traces the function bpf_check, then loading a second CRD and checking for events that record the correct program name and type. Calling the function GetDefaultObserverWithFile twice causes errors since we don’t want to create the fake k8s watcher, load the exporter, etc. again. Instead, for the second CRD, we only get and load the sensors. This approach requires importing a few extra packages, so it may be useful to find a better way to do this. Signed-off-by: Sarah Fujimori <[email protected]>
|
If you're concerned about bloat maybe we could just use cilium/ebpf to load a stub kprobe and attach it? |
jrfastab
reviewed
Aug 3, 2022
pkg/sensors/tracing/kprobe_test.go
Outdated
| } | ||
|
|
||
| b := base.GetInitialSensor() | ||
| if err := b.Load(context.TODO(), option.Config.BpfDir, option.Config.MapDir, option.Config.CiliumDir); err != nil { |
There was a problem hiding this comment.
Looks good to me though should we also unload the program here in the flow?
There was a problem hiding this comment.
Would also be good to replace context.TODO()s here with a single context.Background() like we recently did for other tests.
There was a problem hiding this comment.
the test logs show that the other program (sys_write kprobe) is already being unloaded at the end, so I think that part is fine..
Signed-off-by: Sarah Fujimori <[email protected]>
willfindlay
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a unit test for tracing bpf verifier checks during program loads. We do this by first loading a CRD that traces the function bpf_check, then loading a second CRD and checking for events that record the correct program name and type. Calling the function GetDefaultObserverWithFile twice causes errors since we don’t want to create the fake k8s watcher, load the exporter, etc. again. Instead, for the second CRD, we only get and load the sensors. This approach requires importing a few extra packages, so it may be useful to find a better way to do this.
Signed-off-by: Sarah Fujimori [email protected]