Make relax_verifier() into one instruction #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relax_verifier() is used to cause the verifier to add a prune point that can be helpful in reducing the overall complexity. It does this by calling get_smp_processor_id(); in order to prevent the call from being optimised out, its result is stored in a register and marked with the unused attribute. This results in two assembler instructions, one for the call and one to store the result. It also potentially causes a register spill. This commit changes relax_verifier() into a single assembler instruction to call the helper. This reduces the overall instruction count and reduces complexity. Signed-off-by: Kevin Sheldrake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relax_verifier() is used to cause the verifier to add a prune point that
can be helpful in reducing the overall complexity. It does this by
calling get_smp_processor_id(); in order to prevent the call from being
optimised out, its result is stored in a register and marked with the
unused attribute. This results in two assembler instructions, one for
the call and one to store the result. It also potentially causes a
register spill.
This commit changes relax_verifier() into a single assembler instruction
to call the helper. This reduces the overall instruction count and
reduces complexity.
Signed-off-by: Kevin Sheldrake [email protected]