bpf: fix incorrect inline asm output operands sections #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtardy
changed the title
mtardy
added
the
release-note/misc
|
mmh they are more I missed many, I only searched for |
In some places, certainly because of copy-paste we use the inputs operands instead of the output operands section. Signed-off-by: Mahe Tardy <[email protected]>
After finding a "r+" constraint in a previous inline assembly line that was undetected since it was ignored by the compiler, because it was in the input operands and not the output operands, I searched for more Signed-off-by: Mahe Tardy <[email protected]>
While searching for using input operands while we should use the output operand, I found the "r+" mistake, that is detected when you fix the operands since the compiler no longer ignores it. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/fix-inline-asm
branch
from
4109648 to
9c96566
Compare
You cannot use the '+' modifier constraint on inputs, and here size is not written to. Signed-off-by: Mahe Tardy <[email protected]>
Thanks, I pushed a few other fixes. I'll try to get John's review on this one. |
mtardy
added
the
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places, certainly because of copy-paste we use the inputs operands instead of the output operands section.
I also spotted some incorrect constraints,
r+instead of+rfor example.