fix(install-tetragon.sh) fix 'kind load docker-image' in kind setup #2735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I apologize to @mtardy for recreating this PR. I was doing a quick fix for this very small issue and did not follow the contribution guide. 🙏 |
hehe no need to apologize, thanks for the patch! |
mtardy
added
the
release-note/misc
Fixes cilium#2731 This commit correct the parsing of the yaml output from contrib/kind/values.yaml file in contrib/kind/install-tetragon.sh. A quote is unintentionally added and lead to an error in the tetragon deployment when added in kind. Signed-off-by: Tristan d'Audibert <[email protected]>
ScriptSathi
force-pushed
the
pr/ScriptSathi/fix-install-tetragon.sh
branch
from
9302f3e to
8303e17
Compare
mtardy
approved these changes
Jul 25, 2024
lambdanis
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2731
Description
When running
make kind-setup, the tetragon images are not correctly pushed into kind, which leads to an error loopbackof in the cluster. It happens because of a formatting issue in the./contrib/kind/install-tetragon.shwithyq. Quotes are added and are unnecessary, which lead to this format in bash"\"cilium/tetragon:latest\"".