rthooks: image and helm fixes #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While tagging rthooks/v0.1, the GH action that builds the images failed with: Error: buildx failed with: ERROR: failed to solve: target stage "release" could not be found Rename the final taret to release to fix this. Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
added
the
release-note/misc
Signed-off-by: Kornilios Kourtis <[email protected]>
The v0.1 tag failed to build, so let's move to the next. Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
changed the title
Signed-off-by: Kornilios Kourtis <[email protected]>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tpapagian
approved these changes
Jul 24, 2024
|
Thanks!
I agree wrt to reverting. I have the habit of splitting patches that change code with auto-generation to better deal with conflicts. I'll leave it as and merge the PR, but maybe it would make sense to come up with a general rule on whether we want to split auto-generation with everything else or not. I'm personally on the former camp, but it's just a preference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see patches.