proto: Reserve removed field numbers #2722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
added
the
release-note/misc
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
michi-covalent
force-pushed
the
pr/michi/proto-struggle
branch
from
3c4aa71 to
54dd87d
Compare
There are some gaps in EventType and GetEventsResponse field numbers because some fields got removed from these events. Mark these field numbers as reserved to avoid accidentally re-using them. Move process_lsm field number from 13 to 28 since the field number 13 has already been used in the past. It's still safe to change the field number for process_lsm since we haven't released the process_lsm APIs [^1]. [^1]: #2566 Suggested-by: Lorenz Bauer <[email protected]> Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/proto-struggle
branch
from
54dd87d to
b208532
Compare
kkourt
approved these changes
Jul 24, 2024
olsajiri
approved these changes
Jul 24, 2024
mtardy
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some gaps in EventType and GetEventsResponse field numbers because some fields got removed from these events. Mark these field numbers as reserved to avoid accidentally re-using them.
Move process_lsm field number from 13 to 28 since the field number 13 has already been used in the past. It's still safe to change the field number for process_lsm since we haven't released the process_lsm APIs 1.
Suggested-by: Lorenz Bauer [email protected]
Footnotes
https://github.com/cilium/tetragon/pull/2566 ↩