Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update github.com/cilium/ebpf #2717

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

lmb
Copy link
Contributor

@lmb lmb commented Jul 23, 2024

Manually update the dependency to preempt a broken automated bump. This is because we removed the LogSize field upstream.

@lmb lmb requested a review from a team as a code owner July 23, 2024 08:59
@lmb lmb requested a review from kkourt July 23, 2024 08:59
Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 083c303
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/669f71a5d13dec00082cf54a
😎 Deploy Preview https://deploy-preview-2717--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mtardy
Copy link
Member

mtardy commented Jul 23, 2024

Ah that explains that #2662 with https://github.com/cilium/tetragon/actions/runs/10039047288/job/27742214979?pr=2662#step:8:54

@lmb lmb force-pushed the pr/lmb/update-ebpf-go branch from 2f0a339 to 083c303 Compare July 23, 2024 09:02
@lmb lmb added the release-note/dependency This PR updates one or multiple dependencies label Jul 23, 2024
@lmb
Copy link
Contributor Author

lmb commented Jul 23, 2024

Apparently this now depends on cilium/cilium#33961 🙈

@mtardy
Copy link
Member

mtardy commented Jul 23, 2024

Apparently this now depends on cilium/cilium#33961 🙈

😑 we need to remove that Cilium dep one day or later, it's really annoying

@lmb lmb force-pushed the pr/lmb/update-ebpf-go branch 2 times, most recently from dd63e79 to 7232961 Compare July 23, 2024 10:47
Manually update the dependency and remove usage of the deprecated
LogSize field.

Signed-off-by: Lorenz Bauer <[email protected]>
@lmb lmb force-pushed the pr/lmb/update-ebpf-go branch from 7232961 to a474fbf Compare July 23, 2024 14:35
@lmb
Copy link
Contributor Author

lmb commented Jul 23, 2024

Someone mind re-running the failed test for me? I don't think it's related to this PR.

@kkourt kkourt merged commit 2b40f93 into cilium:main Jul 23, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/dependency This PR updates one or multiple dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants