Define health metrics group #2714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use new helpers from pkg/metrics to define custom metrics and collector. This required defining msg_op label. Before, this label was semi-constrained - the opcodes are known, but in case we hit an unknown opcode (due to a bug), we would still put it in the label. Now this label is defined as constrained, but the collector still doesn't enforce the constraint in any way. The idea is that in the future this label will be fully constrained and shared between different metrics, (currently it's inconsistent - we use msg_op, op, opcode labels for the same thing), so the label is defined in pkg/metrics. Signed-off-by: Anna Kapuscinska <[email protected]>
Use new helpers from pkg/metrics to define custom metrics and collector. Signed-off-by: Anna Kapuscinska <[email protected]>
Use new helpers from pkg/metrics to define custom metrics and collector. Signed-off-by: Anna Kapuscinska <[email protected]>
The idea is that in the future this group will have constrained cardinality and will be enabled by default (in contrast to another group with potentially high cardinality "debug" metrics). This commit only refactors the existing metrics initialization code to use the new framework. The health metrics group contains all metrics that were documented in the "health metrics" section, but in the future some of them will likely be moved to another group. Signed-off-by: Anna Kapuscinska <[email protected]>
lambdanis
added
area/metrics
kevsecurity
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two things happening here:
I had this PR already: #2604 stacked on top of #2606, but then I merged the latter, the base branch got deleted, the PR got closed and I can't reopen it, so opening it again.