Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use different config for development and production #2711

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Jul 22, 2024

Prevent development deployments of the documentation (preview on Netlify) to appear in search engines.

mtardy added 2 commits July 22, 2024 16:35
This will allow to set some settings for development, on preview and
other non-production environment. For example, trying to have an
appropriate robots.txt/headers to prevent search engine indexation on
previews.

Signed-off-by: Mahe Tardy <[email protected]>
Netlify is used only for previews at the moment, we deploy on GitHub
pages.

Signed-off-by: Mahe Tardy <[email protected]>
@mtardy mtardy added area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation. labels Jul 22, 2024
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 0faa8c6
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/669e73a327f01e000852f6d4
😎 Deploy Preview https://deploy-preview-2711--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mtardy added 2 commits July 22, 2024 16:52
Apparently, search engines started referencing content from deploy
preview and the Netlify deploy. Since we use GitHub pages to deploy at
the moment, let's ask robots to not index nor follow when building with
Netlify.

Signed-off-by: Mahe Tardy <[email protected]>
@mtardy mtardy force-pushed the pr/mtardy/docs-config-dev-prod branch from 0faa8c6 to 447d88b Compare July 22, 2024 15:01
@mtardy mtardy marked this pull request as ready for review July 22, 2024 15:04
@mtardy mtardy requested a review from a team as a code owner July 22, 2024 15:04
@mtardy mtardy requested review from jrfastab and paularah July 22, 2024 15:04
Copy link
Contributor

@paularah paularah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtardy mtardy merged commit 358f397 into main Jul 23, 2024
43 checks passed
@mtardy mtardy deleted the pr/mtardy/docs-config-dev-prod branch July 23, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants