tracing: allow only one of kprobes/tracepoints/lsm #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For historic reasons, the tracing sensor has three different aspects: kprobes, tracepoints, and (recently) lsm hooks. Also for historic reasons, we did not allow tracepoints and kprobes in the same policy. With the addition of the LSM sensor (8eb13e8), if a policy includes an lsm section together with either a kprobe section or a tracepoint section, the lsm section will be ignored. This patch rejects policies that have more than one section of kprobes, tracepoints, and lsm hooks in the policy. A better solution would be to decouple the tracing sensor, and create one sensor for kprobes, one for tracepoints, and one for lsm sensors. See: #2706 Fixes: 8eb13e8 Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
added
the
release-note/misc
anfedotoff
approved these changes
Jul 22, 2024
kevsecurity
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For historic reasons, the tracing sensor has three different aspects: kprobes, tracepoints, and (recently) lsm hooks.
Also for historic reasons, we did not allow tracepoints and kprobes in the same policy.
With the addition of the LSM sensor
(8eb13e8), if a policy includes an lsm section together with either a kprobe section or a tracepoint section, the lsm section will be ignored.
This patch rejects policies that have more than one section of kprobes, tracepoints, and lsm hooks in the policy.
A better solution would be to decouple the tracing sensor, and create one sensor for kprobes, one for tracepoints, and one for lsm sensors. See: #2706
CC: @anfedotoff