Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetra: LSM events compact print support #2703

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

anfedotoff
Copy link
Contributor

Adding LSM events compact printing like it is done for kprobes in default case.

It seems that I forgot about tetra compact printing for LSM events. Maybe we can change ❓ symbol to something else to distinguish LSM hooks and kprobes.

@anfedotoff anfedotoff requested a review from a team as a code owner July 20, 2024 10:16
@anfedotoff anfedotoff requested a review from willfindlay July 20, 2024 10:16
@anfedotoff
Copy link
Contributor Author

Hi @kkourt! Please could you have a look?

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I haven't tried it live! Thanks!

pkg/encoder/encoder.go Outdated Show resolved Hide resolved
@mtardy mtardy added the release-note/minor This PR introduces a minor user-visible change label Jul 25, 2024
Adding LSM events compact printing like it is done
for kprobes in default case.

Signed-off-by: Andrei Fedotov <[email protected]>
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 788ddcb
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66a231e6acee500008b226e9
😎 Deploy Preview https://deploy-preview-2703--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kkourt kkourt merged commit b70ad86 into cilium:main Jul 26, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants