filters: implement pod regex filter + misc fixes #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a new filter for filtering by pod name using a regex. Note that we had to use number 7 here and shift everything else over by one. This is tehcnically a breakage but needs to be done for historical compatibility reasons. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/proto
branch
3 times, most recently
from
2f7b5db to
020cbc4
Compare
While we don't currently need to check lists of primitives or enums with the current Tetragon proto, it's possible that this might change in the future. The way the eventchecker is currently set up, it is not equipped to handle this due to type signature mismatches around pointers. Let's fix this by adding the ability to tag inner list fields as being inner fields and adjusting the logic to generate these field checks. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/proto
branch
from
020cbc4 to
25396c7
Compare
|
Its not breaking anything we haven't release yet. |
willfindlay
force-pushed
the
pr/willfindlay/proto
branch
from
e82124a to
187ae54
Compare
Some tests might want to edit the config defaults before they run, so let's make the defaults themselves configurable. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/proto
branch
from
187ae54 to
7de69bb
Compare
willfindlay
changed the title
michi-covalent
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new filter for filtering by pod name using a regex. Note that we
had to use number 7 here and shift everything else over by one. This is technically
a breakage but needs to be done for historical compatibility reasons.
Also rolled in some fixes for the eventchecker.