tests/e2e: clone proto event in rpcchecker #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willfindlay
force-pushed
the
pr/willfindlay/fix-rpc-checker
branch
2 times, most recently
from
03c15bd to
2641328
Compare
mtardy
approved these changes
Jul 18, 2024
olsajiri
approved these changes
Jul 18, 2024
We've occasionally been running into errors in e2e tests about invalid wire format messages and message size mismatches in protobuf. According to golang/protobuf#1609, this is generally related to concurrency issues such as modifying a message during marshalling. Add a Clone() call before sending the event over the channel to mitigate this issue. Signed-off-by: willfindlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/fix-rpc-checker
branch
from
2641328 to
91808e5
Compare
|
Only added a comment, so no need to wait for this to go through CI again. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've occasionally been running into errors in e2e tests about invalid wire format messages and message size mismatches in protobuf. According to golang/protobuf#1609, this is generally related to concurrency issues such as modifying a message during marshalling. Add a Clone() call before sending the event over the channel to mitigate this issue.