Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the tetra CLI install directions for Windows #2683

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

spkane
Copy link
Contributor

@spkane spkane commented Jul 16, 2024

Fix tetra CLI install directions for Windows

Thanks for contributing! Please ensure your pull request adheres to the following guidelines:

  • All commits contain a well written commit message and are signed-off (see Submitting a pull request).
  • All code is covered by unit and/or end-to-end tests where feasible.
  • All generated files are updated if needed (see Making changes).
  • Provide a title or release-note blurb suitable for the release notes (see guidelines).
  • Update documentation and write an upgrade note if needed (see guidelines).
  • Are you a user of Tetragon? Please add yourself to the Users doc in the Cilium repository.
  • Fix the tetra CLI install directions for Windows

@spkane spkane requested review from mtardy and a team as code owners July 16, 2024 22:16
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit e005f6b
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6697e1c9b9f3ca000831f147
😎 Deploy Preview https://deploy-preview-2683--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/content/en/docs/installation/tetra-cli.md Outdated Show resolved Hide resolved
docs/content/en/docs/installation/tetra-cli.md Outdated Show resolved Hide resolved
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks! Yep agree with Michi, if you can group those args and eventually squash your two commits, that would be perfect :)

@mtardy mtardy added area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation. labels Jul 17, 2024
`curl` and `tar` commands didn't work as originally written.

Signed-off-by: Sean P. Kane <[email protected]>
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@spkane
Copy link
Contributor Author

spkane commented Jul 17, 2024

@mtardy and @michi-covalent - Changes made. This should be good to go now.

@spkane
Copy link
Contributor Author

spkane commented Jul 17, 2024

@mtardy I can't merge this personally, so someone else will have to take care of that.

@mtardy mtardy merged commit 4d73b14 into cilium:main Jul 17, 2024
9 checks passed
@mtardy
Copy link
Member

mtardy commented Jul 17, 2024

@mtardy I can't merge this personally, so someone else will have to take care of that.

yeah I know no worries :)

@spkane spkane deleted the patch-1 branch July 17, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants