Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve local k8s developer experience #2673

Merged
merged 9 commits into from
Jul 16, 2024

Conversation

lambdanis
Copy link
Contributor

This set of changes is supposed to improve the developer experience using local kind clusters. It's based on my own experience, so if I'm breaking anyone's workflow then please shout.

The most important changes:

  • make kind-install-tetragon and install-tetragon.sh script install Tetragon in tetragon namespace, not kube-system
  • make kind-install-tetragon builds images by default
  • You can pass additional Helm values to make kind-install-tetragon using VALUES=<path> option
  • Default Helm values used are now in values.yaml file instead of being scattered around install-tetragon.sh script

Ref #1849

When installing Tetragon in kind, usually we want to install the local build,
not the latest release. Let's make it the default.

Signed-off-by: Anna Kapuscinska <[email protected]>
Instead of passing default values to helm via --set options, pass a default
values.yaml file. It's much easier to check the default values if they're all
in one file instead of being scattered around the script.

This commit removes --image and --operator options from install-tetragon.sh
script. The default values.yaml file can be configured via
TETRAGON_KIND_BASE_VALUES envvar (this is useful for developers of Tetragon
distributions where different defaults make sense). Developers can still pass
an additional file via -v/--values option.

Signed-off-by: Anna Kapuscinska <[email protected]>
@lambdanis lambdanis added the release-note/misc This PR makes changes that have no direct user impact. label Jul 14, 2024
@lambdanis lambdanis requested review from mtardy and a team as code owners July 14, 2024 23:32
Copy link

netlify bot commented Jul 14, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 91746e1
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66946021abb4c700092970dc
😎 Deploy Preview https://deploy-preview-2673--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Also, check if yq and kind are installed before using them.

Signed-off-by: Anna Kapuscinska <[email protected]>
Usually when running Tetragon locally in kind, we're iteratively making code
changes and installing it. It's convenient to be able to build and install
Tetragon with just one command, so now it's possible with

  make kind-install-tetragon

It's possible to skip building images by passing KIND_BUILD_IMAGES=0 option,
similarly to how we do it for e2e tests.

Signed-off-by: Anna Kapuscinska <[email protected]>
Additional values can be passed with

  make kind-install-tetragon VALUES=values.yaml

Signed-off-by: Anna Kapuscinska <[email protected]>
@lambdanis lambdanis force-pushed the pr/lambdanis/kind-dev branch from 91746e1 to 1b821a2 Compare July 14, 2024 23:35
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i trust you

@lambdanis lambdanis merged commit 7f4e341 into cilium:main Jul 16, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants