-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve local k8s developer experience #2673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Kapuscinska <[email protected]>
Signed-off-by: Anna Kapuscinska <[email protected]>
Signed-off-by: Anna Kapuscinska <[email protected]>
When installing Tetragon in kind, usually we want to install the local build, not the latest release. Let's make it the default. Signed-off-by: Anna Kapuscinska <[email protected]>
Instead of passing default values to helm via --set options, pass a default values.yaml file. It's much easier to check the default values if they're all in one file instead of being scattered around the script. This commit removes --image and --operator options from install-tetragon.sh script. The default values.yaml file can be configured via TETRAGON_KIND_BASE_VALUES envvar (this is useful for developers of Tetragon distributions where different defaults make sense). Developers can still pass an additional file via -v/--values option. Signed-off-by: Anna Kapuscinska <[email protected]>
lambdanis
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Jul 14, 2024
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Also, check if yq and kind are installed before using them. Signed-off-by: Anna Kapuscinska <[email protected]>
Usually when running Tetragon locally in kind, we're iteratively making code changes and installing it. It's convenient to be able to build and install Tetragon with just one command, so now it's possible with make kind-install-tetragon It's possible to skip building images by passing KIND_BUILD_IMAGES=0 option, similarly to how we do it for e2e tests. Signed-off-by: Anna Kapuscinska <[email protected]>
Additional values can be passed with make kind-install-tetragon VALUES=values.yaml Signed-off-by: Anna Kapuscinska <[email protected]>
Signed-off-by: Anna Kapuscinska <[email protected]>
lambdanis
force-pushed
the
pr/lambdanis/kind-dev
branch
from
July 14, 2024 23:35
91746e1
to
1b821a2
Compare
michi-covalent
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i trust you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes is supposed to improve the developer experience using local kind clusters. It's based on my own experience, so if I'm breaking anyone's workflow then please shout.
The most important changes:
make kind-install-tetragon
andinstall-tetragon.sh
script install Tetragon in tetragon namespace, not kube-systemmake kind-install-tetragon
builds images by defaultmake kind-install-tetragon
usingVALUES=<path>
optionvalues.yaml
file instead of being scattered aroundinstall-tetragon.sh
scriptRef #1849