Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve k8s filtering docs #2671

Merged

Conversation

paularah
Copy link
Contributor

This patch improves the k8s filtering section of the docs by

  1. Specifying the correct directory for installing the OCI runtime hooks in minikube.

  2. Specifying the correct command for retrieving the tetragon operator logs.

  3. A more specific name for tracing policy for filtering by container field.

  4. General grammar improvements.

Thanks for contributing! Please ensure your pull request adheres to the following guidelines:

  • All commits contain a well written commit message and are signed-off (see Submitting a pull request).
  • All code is covered by unit and/or end-to-end tests where feasible.
  • All generated files are updated if needed (see Making changes).
  • Provide a title or release-note blurb suitable for the release notes (see guidelines).
  • Update documentation and write an upgrade note if needed (see guidelines).
  • Are you a user of Tetragon? Please add yourself to the Users doc in the Cilium repository.

This patch improves the k8s filtering section of the docs by

1. Specifying the correct directory for installing the OCI runtime hooks in minikube.

2. Specifying the right command for retrieving the  tetragon operator logs.

3. A more specific name for tracing policy for filtering by container field.

4. General grammer improvements.

Signed-off-by: Paul Arah <[email protected]>
@paularah paularah requested review from mtardy and a team as code owners July 12, 2024 21:15
Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit db969c7
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66919ceb8151d200081c62d9
😎 Deploy Preview https://deploy-preview-2671--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! :)

@mtardy mtardy added area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation. labels Jul 15, 2024
@mtardy mtardy merged commit cbe3c4a into cilium:main Jul 16, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants