Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release_template: also push API tag #2664

Merged
merged 1 commit into from
Jul 24, 2024
Merged

release_template: also push API tag #2664

merged 1 commit into from
Jul 24, 2024

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Jul 12, 2024 •
edited
Loading

See commit.

@kkourt
release_template: also push API tag
d2dcc6f 
As noted in
#2542 (comment).
the instructions miss the part of pushing the api tag to the remote
repo.

Fixes: cf0a49d "release_template: also tag API module"

Signed-off-by: Kornilios Kourtis <[email protected]>
@kkourt kkourt added the release-note/misc This PR makes changes that have no direct user impact. label Jul 12, 2024
@kkourt kkourt requested a review from a team as a code owner July 12, 2024 10:00
@kkourt kkourt requested a review from jrfastab July 12, 2024 10:00
@kkourt kkourt mentioned this pull request Jul 12, 2024
Closed
15 tasks
@netlify Netlify
Copy link

netlify bot commented Jul 12, 2024

✅ Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit d2dcc6f
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6690fed26450b30008c7f839
😎 Deploy Preview https://deploy-preview-2664--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mtardy
mtardy approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good because we filter correctly in the Makefile, it produced some issues to add new tags prefixes in the past but I think the regex is correct now.

@kkourt
Copy link
Contributor Author

kkourt commented Jul 24, 2024

I think it's good because we filter correctly in the Makefile, it produced some issues to add new tags prefixes in the past but I think the regex is correct now.

Yap, I changed the VERSION command when I added yet another tag for rthooks images (rthooks/v*)

@kkourt kkourt merged commit c3db50b into main Jul 24, 2024
35 checks passed
@kkourt kkourt deleted the pr/kkourt/release-push-api-tag branch July 24, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtardy mtardy mtardy approved these changes

@jrfastab jrfastab Awaiting requested review from jrfastab jrfastab is a code owner automatically assigned from cilium/tetragon

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkourt @mtardy