Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rthook images updates #2663

Merged
merged 3 commits into from
Jul 12, 2024
Merged

rthook images updates #2663

merged 3 commits into from
Jul 12, 2024

Conversation

kkourt
Copy link
Contributor

@kkourt kkourt commented Jul 12, 2024

See patches

kkourt added 2 commits July 12, 2024 11:14
8dd832b
excluded the api/* pattern from the version. We want to introduce a new
tag for the rthooks images, where by tagging the with rthooks/v0.1,
rthooks images will be generated with this tag.

Updat the VERSION detection by excluding everything that includes `/`.

Signed-off-by: Kornilios Kourtis <[email protected]>
This reverts commit 101fd8c.

The above commit was wrong. For releasing the tetragon-rthooks images,
we need a different workflow, which will be based on rthooks/v* tags.

The original intention of the commit, was to build the rthooks images in
CI. This patch actually does this.

Fixes: 101fd8c "gh: build rthooks image (CI)"

Signed-off-by: Kornilios Kourtis <[email protected]>
@kkourt kkourt added the release-note/misc This PR makes changes that have no direct user impact. label Jul 12, 2024
@kkourt kkourt requested review from willfindlay and a team as code owners July 12, 2024 09:34
@kkourt kkourt changed the title Pr/kkourt/rthooks images fix rthook images updates Jul 12, 2024
This commit adds a worfklow for building rthooks images.

rthooks images (tetragon-rthooks) are used by the tetragon-rthooks
daemonset to setup the tetragon container runtime hook.
See: #2608 for more details.

The release images are build using rthooks/v* tags. So tagging
`rthooks/v0.1`, will end up generating a tetragon-rthooks:v0.1 image.

Signed-off-by: Kornilios Kourtis <[email protected]>
@kkourt kkourt merged commit 173821c into main Jul 12, 2024
38 checks passed
@kkourt kkourt deleted the pr/kkourt/rthooks-images-fix branch July 12, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants