Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tetragon build #2659

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fix tetragon build #2659

merged 1 commit into from
Jul 12, 2024

Conversation

tpapagian
Copy link
Member

@tpapagian tpapagian commented Jul 12, 2024 •
edited
Loading

Thanks for contributing! Please ensure your pull request adheres to the following guidelines:

  • All commits contain a well written commit message and are signed-off (see Submitting a pull request).
  • All code is covered by unit and/or end-to-end tests where feasible.
  • All generated files are updated if needed (see Making changes).
  • Provide a title or release-note blurb suitable for the release notes (see guidelines).
  • Update documentation and write an upgrade note if needed (see guidelines).
  • Are you a user of Tetragon? Please add yourself to the Users doc in the Cilium repository.

f44ce8c removed "github.com/cilium/tetragon/pkg/option" import from pkg/sensors/program/loader.go. This is merged without a rebase to latest master.

81a3e14 adds a new dependancy on "github.com/cilium/tetragon/pkg/option" so removing that in the first commit breaks the build.

This patch fixes that.

Fix a build issue in tetragon binary.

@tpapagian tpapagian added the release-note/misc This PR makes changes that have no direct user impact. label Jul 12, 2024
@tpapagian tpapagian requested a review from a team as a code owner July 12, 2024 07:59
@tpapagian tpapagian requested a review from kevsecurity July 12, 2024 07:59
@tpapagian
Fix tetragon build
0405447 
f44ce8c
removed "github.com/cilium/tetragon/pkg/option" import from
pkg/sensors/program/loader.go. This is merged without a rebase to latest
master.

81a3e14
adds a new dependency on "github.com/cilium/tetragon/pkg/option" so
removing that in the first commit breaks the build.

This patch fixes that.

Signed-off-by: Anastasios Papagiannis <[email protected]>
@tpapagian tpapagian force-pushed the pr/apapag/fix-build-issue branch from ba16426 to 0405447 Compare July 12, 2024 08:06
mtardy
mtardy approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's the downside of not having a merging queue I guess

@tpapagian tpapagian merged commit ba27120 into main Jul 12, 2024
39 checks passed
@tpapagian tpapagian deleted the pr/apapag/fix-build-issue branch July 12, 2024 08:55
@tpapagian tpapagian mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtardy mtardy mtardy approved these changes

@kevsecurity kevsecurity Awaiting requested review from kevsecurity kevsecurity is a code owner automatically assigned from cilium/tetragon

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpapagian @mtardy