tetragon: small improvement to testing merge sensors #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding some more tests discovered that its sometimes useful to explicitly list progs and maps for clarity. But, the testing utilities mark the test Fatal when this happens. Its not really an error to over specify a test so lets just allow it and have the merge logic skip it. Signed-off-by: John Fastabend <[email protected]>
jrfastab
added
the
release-note/misc
michi-covalent
approved these changes
Jul 12, 2024
jrfastab
force-pushed
the
pr/jrfastab/generalizeDups
branch
2 times, most recently
from
5e07bb8 to
af5c7da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some more tests discovered that its sometimes useful to explicitely list progs and maps for clarity. But, the testing utilities mark the test Fatal when this happens. Its not really an error to over specify a test so lets just allow it and have the merge logic skip it.
Without this its annoying to define tests for if multiple sensors work together. For example we have sensor tests with SensorX and another with SensorY if you want to test SensorX+SensorY looks good you get a Fatal just because logic doesn't know how to merge the defintiion of Maps/Progs. Or you have to cut'n'paste it all over again.