Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update label on hero section on main page #2644

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

annaindistress
Copy link
Contributor

@annaindistress annaindistress commented Jul 5, 2024

This PR updates label in hero section on home page

@annaindistress annaindistress requested review from mtardy and a team as code owners July 5, 2024 16:41
Copy link

netlify bot commented Jul 5, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit c1b428a
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/668bb8e24856df0008adfaf2
😎 Deploy Preview https://deploy-preview-2644--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks! It seems there is a small issue
image

feel free to check the preview of your changes on https://deploy-preview-2644--tetragon.netlify.app/.

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely! could you squash your commits into one?

@mtardy mtardy added area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation. labels Jul 8, 2024
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure! to me it's fine, let's ask for @xmulligan and @paularah opinions

@mtardy mtardy requested review from xmulligan and paularah July 8, 2024 11:05
@mtardy
Copy link
Member

mtardy commented Jul 8, 2024

you miss an empty line between your commit message and signature however, see checkpatch

Copy link
Contributor

@paularah paularah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtardy mtardy merged commit 7816c80 into cilium:main Jul 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants