chore: fix vendor target and run make vendor #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willfindlay
force-pushed
the
pr/willfindlay/fix-generated-files
branch
5 times, most recently
from
dc81b3b to
57167bf
Compare
We were using go 1.17 in CI, let's bump it to 1.18. Signed-off-by: William Findlay <[email protected]>
api/ and pkg/k8s/ are now separate go modules, let's add a vendor target for them and call it from the main vendor target. Signed-off-by: William Findlay <[email protected]>
Everything was out of sync due to vendoring issues fixed in the last commit. Signed-off-by: William Findlay <[email protected]>
willfindlay
force-pushed
the
pr/willfindlay/fix-generated-files
branch
from
57167bf to
09ce885
Compare
michi-covalent
approved these changes
Jul 26, 2022
|
@kkourt I'm going to merge this since it's fairly urgent and I got an ack from @michi-covalent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just merged #260 but it seems that the CI job was out of sync with main and did not account for the new module split. So let's update the make vendor target to make this situation impossible. See individual commits.