policyfiletr K8s test fix #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've noticed a flake in the pkg.policyfilter.TestK8s The test uses a fake k8s clientset, applies changes (e.g., adding or removing pods), and then checks whether the policyfilter bpf map has the expected contents. We need to check the state after the pod informer callbacks have be called. To do so, we maintain an operation count. We check that all operations have been completed and then compare the contents of the policyfilter map. We seem to be increasing the counter first and then calling the callback, however, which means that there is a small race where the counts match but the bpf map contents have not been updated. This patch increases the counters after the callback returns. This seems to fix the issue in my local machine. Signed-off-by: Kornilios Kourtis <[email protected]>
Signed-off-by: Kornilios Kourtis <[email protected]>
The vmtests README uses outdated images. Update to the proper images. Signed-off-by: Kornilios Kourtis <[email protected]>
kkourt
added
area/ci
tpapagian
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed a flake in the pkg.policyfilter.TestK8s
The test uses a fake k8s clientset, applies changes (e.g., adding or
removing pods), and then checks whether the policyfilter bpf map has the
expected contents.
We need to check the state after the pod informer callbacks have be
called. To do so, we maintain an operation count. We check that all
operations have been completed and then compare the contents of the
policyfilter map.
We seem to be increasing the counter first and then calling the
callback, however, which means that there is a small race where the
counts match but the bpf map contents have not been updated.
This patch increases the counters after the callback returns.
This seems to fix the issue in my local machine.
Also, two more minor updates.
Fixes: #2470