Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm, doc: Added debug Helm flag for the agent #2622

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

PhilipSchmid
Copy link
Collaborator

Added a debug Helm flag for the Tetragon agent. Implemented via ConfigMap flag. The Tetragon DaemonSet will be restarted automatically after changing the debug value.

helm, doc: Added debug Helm flag for the agent

@PhilipSchmid PhilipSchmid requested review from a team and mtardy as code owners July 1, 2024 16:30
Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 0590be2
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/6685768225006800081e3596
😎 Deploy Preview https://deploy-preview-2622--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lambdanis lambdanis added release-note/minor This PR introduces a minor user-visible change area/helm Related to the Helm chart labels Jul 3, 2024
Added a `debug` Helm flag for the Tetragon agent. Implemented via
ConfigMap flag. The Tetragon DaemonSet will be restarted automatically
after changing the debug value.

Signed-off-by: Philip Schmid <[email protected]>
@PhilipSchmid PhilipSchmid force-pushed the pr/philip/helm_debug_option branch from df15a92 to 0590be2 Compare July 3, 2024 16:04
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just some remarks, no need to modify stuff

### Change log level on Kubernetes

{{< warning >}}
The Tetragon DaemonSet will be restarted automatically after changing the debug Helm value!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pedantic nit, I don't mind not changing this, just a suggestion:

Suggested change
The Tetragon DaemonSet will be restarted automatically after changing the debug Helm value!
The Pods of the Tetragon DaemonSet will be restarted automatically after changing the debug Helm value.

Comment on lines +100 to +101
It is possible to change the log level of the Tetragon (DaemonSet) instances by
setting `tetragon.debug` to `true`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is possible to change the log level of the Tetragon (DaemonSet) instances by
setting `tetragon.debug` to `true`.
It is possible to change the log level of Tetragon's DaemonSet Pods by
setting `tetragon.debug` to `true`.

@lambdanis
Copy link
Contributor

I'm merging this, so that I can rebase and merge #2625. Feel free to address Mahe's feedback in another PR :)

@lambdanis lambdanis merged commit 8cb39f4 into cilium:main Jul 9, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Related to the Helm chart release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants