Move metrics registry and initialization to pkg/metricsconfig #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, metrics registry was defined in pkg/metrics and initialization functions in pkg/metrics/metricsconfig. It make sense to keep them together and outside of pkg/metrics, which contains a library for defining metrics. Now all code related to running the metrics server sits in pkg/metricsconfig. Signed-off-by: Anna Kapuscinska <[email protected]>
lambdanis
added
area/metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, metrics registry was defined in
pkg/metricsand initialization functions inpkg/metrics/metricsconfig. It make sense to keep them together and outside ofpkg/metrics, which contains a library for defining metrics. Now all code related to running the metrics server sits inpkg/metricsconfig.I took this out of #2604 to make it easier to stack PRs.